Skip to content

Comments

8353568: SEGV_BNDERR signal code adjust definition#24441

Closed
MBaesken wants to merge 2 commits intoopenjdk:masterfrom
MBaesken:JDK-8353568
Closed

8353568: SEGV_BNDERR signal code adjust definition#24441
MBaesken wants to merge 2 commits intoopenjdk:masterfrom
MBaesken:JDK-8353568

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 4, 2025 •
edited by openjdk bot
Loading

There was a remark from Thomas Stuefe in openjdk/jdk24u#175 .

The idea was to add a static assert for SEGV_BNDERR sig-code.
The static assert will alert us if we build on a newer Linux version and turns out we were wrong with our assumed number.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353568: SEGV_BNDERR signal code adjust definition (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24441/head:pull/24441
$ git checkout pull/24441

Update a local copy of the PR:
$ git checkout pull/24441
$ git pull https://git.openjdk.org/jdk.git pull/24441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24441

View PR using the GUI difftool:
$ git pr show -t 24441

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24441.diff

Using Webrev

Link to Webrev Comment

@MBaesken
Copy link
Member Author

MBaesken commented Apr 4, 2025

@tstuefe this is the PR for for suggestion regarding SEGV_BNDERR signal code handling.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025 •
edited
Loading

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353568: SEGV_BNDERR signal code adjust definition

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b92a443: 8353471: ZGC: Redundant generation id in ZGeneration
  • cfcb330: 8353681: jpackage suppresses errors when executed with --verbose option
  • 10d1fec: 8353679: Restructure classes in jdk.jpackage.internal package
  • 1161b56: 8353053: (fs) Add support for UserDefinedFileAttributeView on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8353568: SEGV_BNDERR signal code adjust definition 8353568: SEGV_BNDERR signal code adjust definition Apr 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025 •
edited
Loading

Webrevs

tstuefe
tstuefe approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and imho trivial. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2025
@MBaesken
Copy link
Member Author

MBaesken commented Apr 7, 2025

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit 6abf4e6.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@MBaesken Pushed as commit 6abf4e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tstuefe tstuefe tstuefe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MBaesken @tstuefe